search

zk1931 / jzab

ZooKeeper Atomic Broadcast in Java
http://zk1931.github.io/jzab/master/
Apache License 2.0
54 stars 23 forks source link

New logic for synchronization. #197

Closed EasonLiao closed 10 years ago

EasonLiao commented 10 years ago

@m1ch1

EasonLiao commented 10 years ago

We have enough unit tests to cover different cases. ZabTest.testSynchronizationCase*, all the cases are covered by the unit test and I checked this by looking at the log.

ghost commented 10 years ago

but they don't take snapshots, do they?

On Wed, Nov 12, 2014 at 11:45 PM, Yisheng Liao notifications@github.com wrote:

We have enough unit tests to cover different cases. ZabTest.testSynchronizationCase*, all the cases are covered by the unit test and I checked this by looking at the log.

Reply to this email directly or view it on GitHub https://github.com/zk1931/jzab/pull/197#issuecomment-62852956.

EasonLiao commented 10 years ago

Yes, the SnapshotTest also covers the cases of taking snapshot. I'll check the log see if it covers all the cases.

ghost commented 10 years ago

we should check in https://github.com/zk1931/jzab/pull/190 first.

it looks like there is only one test testSnapshotSynchronization. our current coverage is pretty weak i think.

On Wed, Nov 12, 2014 at 11:51 PM, Yisheng Liao notifications@github.com wrote:

Yes, the SnapshotTest also covers the cases of taking snapshot. I'll check the log see if it covers all the cases.

Reply to this email directly or view it on GitHub https://github.com/zk1931/jzab/pull/197#issuecomment-62853453.

EasonLiao commented 10 years ago

@m1ch1