search

zkBob / fawkes-crypto

Fawkes-Crypto - zkSNARKs framework
https://github.com/zeropoolnetwork/fawkes-crypto
Apache License 2.0
2 stars 1 forks source link

Minor fixes #4

Closed AllFi closed 1 year ago

AllFi commented 1 year ago
  1. Replace ssh with https in phase2-bn254 dependency. Since phase2-bn254 is public now ssh is not necessary. ssh is not convenient for building images.
  2. Prevent panic during SizedVec deserialization. It is necessary to handle bad requests in zkbob-prover properly.
AllFi commented 1 year ago

Prevent panic during SizedVec deserialization.

Btw, what exactly was the issue with panic? It looks like deserialize always returns a Result.

deserialize calls from_iter: image from_iter contains expect: image this expect panics when the size of provided iter is not enough.

It is not what you are expecting trying to deserialize something so I decided to fix it.