Added `WitnessField` associated type in `Symbolic` class

zkFold / zkfold-base

ZkFold's Base library

https://zkfold.io

MIT License

17 stars 7 forks source link

Added `WitnessField` associated type in `Symbolic` class #353

Closed TurtlePU closed 1 week ago

TurtlePU commented 2 weeks ago

Adds WitnessField associated type in Symbolic class on the way to resolve #307

Note that I had to change a basic interface of Symbolic (and it arguably became better). This also unlocks a cleaner implementation of #219

TurtlePU commented 2 weeks ago

Sorry, marked #307 as resolvable by mistake, there needs to be another PR to add witness function to Symbolic interface: #354 (to merge after this PR is merged)

vlasin commented 1 week ago

Looks good to me!