search

zkFold / zkfold-cardano

zkFold: Cardano integration library
https://zkfold.io
MIT License
5 stars 0 forks source link

Plonk verifier E2E example #18

Closed ajuggler closed 3 months ago

ajuggler commented 3 months ago

Plonk verifier E2E example now runs correctly on both SanchoNet and local testnet. Updated documentation on ./e2e-test/README.md.

ajuggler commented 3 months ago

Note that forwardingMint validator is now parameterized by an integer. Motivation for this is that its address was getting very crowded with UTxOs. Giving a different integer parameter now results in a different address.

vlasin commented 3 months ago

Looking great, Antonio! One suggestion: how difficult will it be to merge local-testnet folder with the e2e-test folder? Specifically, we currently have almost the same script files for posting transactions in the ZK-KYC example for sancho.net and for the local testnet. I think it would be easier to maintain.

zlonast commented 3 months ago

This looks great to me too. I think we should switch from JSON to CBOR entirely.

ajuggler commented 3 months ago

Looking great, Antonio! One suggestion: how difficult will it be to merge local-testnet folder with the e2e-test folder? Specifically, we currently have almost the same script files for posting transactions in the ZK-KYC example for sancho.net and for the local testnet. I think it would be easier to maintain.

Yes, I think it is desirable and easy to implement, will do.

ajuggler commented 3 months ago

Moved local-testnet to e2e-test. Now plonk-example transactions are executed by the same scripts for both SanchoNet and local-testnet. (Only initialization scripts are different.) Updated e2e-test/README .

ajuggler commented 3 months ago

This looks great to me too. I think we should switch from JSON to CBOR entirely.

Done.