zkSync-Community-Hub / community-code

A collaborative repository featuring community-contributed guides for developing on zkSync Era.

https://code.zksync.io

Apache License 2.0

5 stars 3 forks source link

Closed uF4No closed 2 months ago

uF4No commented 2 months ago

What :computer:

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 66f5380):

_{(expires Thu, 23 May 2024 14:55:37 GMT)}

_{Sign: 1b876338aafcf55b4a02f1877984e116731756b1}

dutterbutter commented 2 months ago

@itsacoyote a couple UI nit picks, we can update these in subsequent PRs but want to highlight:

Seems the card selector border is off on out-sized cards. See image below
I don't think we should show ALL the tutorials on the first page. Rather limit to featured posts.
Search bar is absent.

Let me know if you want these made into linear tickets or gh issues.

dutterbutter commented 2 months ago

@itsacoyote fine to merge but please respond to the above comment.

itsacoyote commented 2 months ago

@dutterbutter

Card mis-layout is a design issue I'm planning to fix in a separate ticket. I'll create that.
Displaying featured tutorials on the landing page is definitely a feature to add in. I'll set up a ticket for that as well. I don't have the flag set up yet but I do want a way to tag tutorials as "featured".
I disabled the search bar but can bring it back in in another ticket. There are some configuration tweaks I need to investigate with getting all the tutorial data in yml files to display properly. This would be part of having a filtering/search system.

dutterbutter commented 2 months ago

👍