zkat / make-fetch-happen

Get in loser, we're making requests!

Other

384 stars 27 forks source link

Closed yyjdelete closed 7 years ago

yyjdelete commented 7 years ago

Known Issue:

[ ] npm ERR! cb() never called! when use socks-proxy and connect to http. [ ] node is waiting all proxy conns to disconnected before exit.

zkat commented 7 years ago

OH NO. I'm so sorry I completely missed this PR when I went and implemented my own. It was an accident 😭

zkat commented 7 years ago

Thank you so much for this and the suggestion before. I jumped the gun >_<

zkat commented 7 years ago

wait this code's actually more correct than mine. I'm gonna pull it in anyway 🆗

zkat commented 7 years ago

I merged this and it's been released. It's part of beta.60 now. Cheers!