zkat / make-fetch-happen

Get in loser, we're making requests!
Other
384 stars 27 forks source link

fix(license): switch to ISC #49

Closed zkat closed 6 years ago

zkat commented 6 years ago

As part of the ongoing relicensing process, this changes the license over to one more palatable to open source consumers.

BREAKING CHANGE: license changed from CC0 to ISC.

NOTE

This requires consent from all contributors. If you're on the list below, please reply with "I agree" or a đź‘Ť or something similar to let me know you're ok with your changes being included in this relicensing.

The reason this is happening is because it's pretty hard for some folks to use CC0 stuff, since it's not an OSI-approved license. ISC is the license used by the npm CLI, so I'm switching to it for convenience. We ran all this through our company lawyer before going about it, too, and it's part of a number of relicensing PRs that are happening to related projects I've worked on! Let me know if you have any questions!

yyjdelete commented 6 years ago

đź‘Ť

nlkluth commented 6 years ago

đź‘Ť

bitinn commented 6 years ago

I need a bit of a primer on changing license on a forked project. It’s totally fine for node-fetch to keep MIT, and the forked project node-fetch-npm can use whatever it likes, true? Does MIT permit that? Does it require original license to be in place?

Other than that I have no problem with this really.

(From my phone)

On 15 Nov 2017, at 11:13, Nathan Kluth notifications@github.com wrote:

đź‘Ť

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

zkat commented 6 years ago

@bitinn I can't change the license on node-fetch-npm, so that stays MIT. This applies solely to the m-f-h codebase, which doesn't share code with node-fetch. In order to change the license for node-fetch-npm, I would require permission from all contributors of that project. MIT is perfectly fine, though, and has basically the same benefits as ISC in this context, so I wouldn't even want to do that.

Since node-fetch is MIT, that also means it's not required for dependents to adopt that license.

colinrotherham commented 6 years ago

đź‘Ť

bitinn commented 6 years ago

@zkat Thx, I was confused by the “ongoing relicense” part of the sentence. Your explanation clears it up.

Thumbs up to this change.

(From my phone)

On 15 Nov 2017, at 14:19, Kat Marchán notifications@github.com wrote:

@bitinn I can't change the license on node-fetch-npm, so that stays MIT. This applies solely to the m-f-h codebase, which doesn't share code with node-fetch. In order to change the license for node-fetch-npm, I would require permission from all contributors of that project. MIT is perfectly fine, though, and has basically the same benefits as ISC in this context, so I wouldn't even want to do that.

Since node-fetch is MIT, that also means it's not required for dependents to adopt that license.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

SimenB commented 6 years ago

đź‘Ť

zkat commented 6 years ago

@bitinn ahh, that was me referencing similar relicensing efforts for cacache, pacote, and the other npm5-related libraries, which I was defaulting to CC0 before realizing the issues that would cause in practice (I'd been using that license for years).

miiihi commented 6 years ago

đź‘Ť

On Wed, Nov 15, 2017 at 7:59 AM, Kat Marchán notifications@github.com wrote:

@bitinn https://github.com/bitinn ahh, that was me referencing similar relicensing efforts for cacache, pacote, and the other npm5-related libraries, which I was defaulting to CC0 before realizing the issues that would cause in practice (I'd been using that license for years).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zkat/make-fetch-happen/pull/49#issuecomment-344503474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjzMIhhX-4Ydb7t_-G1bP8BCC7GjGGaks5s2ovcgaJpZM4QeTzV .

cilice commented 6 years ago

:+1:

tmyt commented 6 years ago

:+1: