zkat / miette

Fancy extension for std::error::Error with pretty, detailed diagnostic printing.
https://docs.rs/miette
Apache License 2.0
1.85k stars 106 forks source link

Can't get `syntect-highlighter` to work #337

Open froth opened 5 months ago

froth commented 5 months ago

I tried to get syntax highlighting to work according to the new Readme section, but could not succeed. I think the problem is somewhere on my side but I can't figure it out.

I created this minimal project https://github.com/froth/miette-highlighting/blob/main/src/main.rs and it does not highlight on my machine. Screenshot from 2024-02-06 09-41-05

The same code is highlighted correctly using cargo run --example syncat test.rs in https://github.com/trishume/syntect/.

zkat commented 4 months ago

cc @kallisti-dev

erratic-pattern commented 3 months ago

@froth I was able to reproduce this issue with the provided example crate just a month ago, but now it's working... exact same miette version.

So I am wondering if this is somehow related to terminal color detection. Maybe either a bugfix in the supports-color crate resolved the issue or maybe my local terminal emulator patched something (I'm running Wezterm with tmux on Mac OS). Just throwing some ideas out there but nothing is confirmed at this point.

Which terminal emulators/multiplexers are you using when running this? Can you do a clean build (rm -rf target) on the example crate and verify that you are still having this issue?

froth commented 3 months ago

Thanks for having a look @erratic-pattern!

rm -rf target did not change anything for me.

I also tried cargo upgrade and removing Cargo.lock. Both not successful for me.

I am using zsh in tmux in gnome-terminal. Additionally I tried xterm with bash without tmux.

Very weird that it somehow fixed itself for you.