search

zkat / miette

Fancy extension for std::error::Error with pretty, detailed diagnostic printing.
https://docs.rs/miette
Apache License 2.0
1.85k stars 106 forks source link

Add `#[cold]` to some of the constructor functions #375

Closed Boshen closed 1 week ago

Boshen commented 1 month ago

While going over the commit history of anyhow, I see that https://github.com/dtolnay/anyhow/commit/fa9bcc0457a2e51593b874cc2f8bcb5608ad43fe may benefit us as well, should we copy them over?

background issue: https://github.com/dtolnay/anyhow/issues/165

zkat commented 1 month ago

I'd definitely take a PR doing this!

re-taro commented 1 month ago

@zkat Hello! I would like to address this issue!

Boshen commented 1 month ago

@zkat Hello! I would like to address this issue!

Feel free to submit a PR.