search

zkat / miette

Fancy extension for std::error::Error with pretty, detailed diagnostic printing.
https://docs.rs/miette
Apache License 2.0
1.85k stars 106 forks source link

feat(SourceSpan): add impl From<InclusiveRange> #385

Closed Benjamin-L closed 1 week ago

Benjamin-L commented 2 weeks ago

This can be used to avoid awkward start..(end + 1) constructions, which will trigger the clippy::range_plus_one lint.

I added a single impl for InclusiveRange rather than a blanket impl<T: RangeBounds> From<T> for SourceSpan for two reasons. The first is that the blanket impl would be a breaking change (because dependent crates may currently define a type T: RangeBounds and also have impl From<T> for SourceSpan). The second is that this would allow one-sided ranges (..x, x..). In order to support bounded-below ranges, we would need to change SourceSpan so that length may depend on the the specific SourceCode instance. That seems like an unlikely use case.

Benjamin-L commented 2 weeks ago

CI should be fixed by https://github.com/zkat/miette/pull/382