search

zkavtaskin / Domain-Driven-Design-Example

Blog series supplementary domain-driven design C# repository that (hopefully) actually makes sense.
1.75k stars 443 forks source link

Made API more ideomatic, added Postman request collection #1

Closed eqr closed 2 weeks ago

eqr commented 7 years ago

Hello there is a little change that makes API more Restful and also adds Postman request collection to easily consume it.

zkavtaskin commented 7 years ago

Hi, thanks for this! The reason why everything is [HttpGet] is because it's much easier to play with the API, there is no need to install anything.

There are number of things we can do now: A) Merge in your postman collection and ignore the HttpDelete and Patch changes. B) Merge in your postman collection, HttpDelete patch, etc changes and update https://github.com/zkavtaskin/Domain-Driven-Design-Example/blob/master/README.md so that it reflects the proposed changes.

Maybe there is another option? I would like to keep the simplicity. What do you think?

eqr commented 7 years ago

What do you think about API versioning? We can leave everything with HttpGet as v1 and expose my version as v2.

zkavtaskin commented 7 years ago

That is a great idea! Would you like to update your pull request?