Add `.attach_models()` action to provide easy way to convert from `Rainbow` to `RainbowWithModel`.

zkbt / chromatic

Tools for visualizing spectrosopic light curves, with flux as a function of wavelength and time.

MIT License

14 stars 4 forks source link

Add `.attach_models()` action to provide easy way to convert from `Rainbow` to `RainbowWithModel`. #152

Closed zkbt closed 2 years ago

zkbt commented 2 years ago

To support https://github.com/catrionamurray/chromatic_fitting/issues/12, we should add a .attach_models() function to make it easier to generate a RainbowWithModel from a Rainbow. I think the calling sequence should look like:

rainbow.attach_models(model={some array}, transit_model={some array}, ...)

with only the first one being actually required.

zkbt commented 2 years ago

Ha! No wonder I had a clear picture of what I wanted this function to do; I had already written it exactly here. I'm sheepishly marking this as closed, and taking this as a lesson that maybe it's time for me to switch focus over to #141 .