search

zkbt / mosasaurus

Tools for extracting chromatic lightcurves from MultiObject Spectrograph data.
MIT License
3 stars 1 forks source link

add a DIS instrument for the APO-DIS spectrograph #17

Closed zkbt closed 6 years ago

zkbt commented 6 years ago

This Pull Request would add a new Spectrograph for extracting spectra from the Dual Imaging Spectrograph at the APO 3.5m.

It mostly just adds new features through the DIS class definition, but there were a few changes to the interface overall that could potentially affect LDSS3 or IMACS. I started this from the master branch, and I think all the changes that could potentially affect the Magellan instruments are included in the changes made here to LDSS3C. I tested it on my own laptop, and LDSS3 still seems to be working OK for me.

@hdiamondlowe, do you think we could merge this into the master branch? When you’re OK with this, can you please either accept the pull request, or give me the go-ahead to do it? It’d be super swell if you could also check to make sure this hasn’t broken LDSS3 for you, at least in any obvious way.

I think it makes sense to merge DIS in before your IMACS branch, because most of the changes here are pretty self-contained to the new spectrograph definition, while it looks like you’ve made some more modifications throughout. It’d be good to merge IMACS in soon too, I think, but that can be another discussion!

zkbt commented 6 years ago

I should note, because DIS has two cameras (a red and a blue), I changed the way directories are organized a little bit in here. Previously, we'd make a working directory that was basically {night}_{object} to contain everything. I've changed that now to a nested directory structure with {disperser}/{night}/{object}. This should work seamlessly for LDSS, but I worry it might still wobble a bit with IMACS. Let's watch out for it!

This structure would have the advantage of (down the road) allowing us to analyze lots of targets using the same calibration data for an instrument (for example if darks and biases never change), or for the same night (for example if lots of single-object targets are in the same place on the detector).