search

zkbt / mosasaurus

Tools for extracting chromatic lightcurves from MultiObject Spectrograph data.
MIT License
3 stars 1 forks source link

Generalize to other multiobject spectrographs? #8

Closed zkbt closed 6 years ago

zkbt commented 8 years ago

In CCD.py, the createStitched function assumes there are two amplifiers and a particular geometry for how they're stitched together. This would have to be generalized.

Some aspects of the detector geometry are defined in .obs files. That would have to be modified for other cameras. Also, the gain.

The wavelength calibration guess files depend on the grism specified in the .obs file. New guess files would have to be generated for a different spectrograph.

zkbt commented 6 years ago

@hdiamondlowe, looking a bit at your IMACS branch, I think you have IMACS-specific createStitched and lots of CCD management stuff inside CCD.py and Calibration.py. Ultimately (long-term, no rush), it'd be great if we could move those into the IMACS.py definition, so that they don't affect other spectrographs. This is not urgent at all, but I thought I'd mention it here, while this was fresh from just having done it with DIS.

zkbt commented 6 years ago

OK, @hdiamondlowe, as we discussed, I've moved my createStitched back to CCD.py. I think all you need to do now is use IMACS.py to define IMACS-specific instrument functions for loadSingleCCD (I used to call this loadAndTrim, and it's basically your stitchChips), darkexptime, and gain.

zkbt commented 6 years ago

I think we have DIS, LDSS, and IMACS nicely separated. Each of these can also be a template for adding future instruments if we like!