Batch Verification API - Githubissues

zkcrypto / bellman

zk-SNARK library.

Other

988 stars 534 forks source link

Batch Verification API #59

Closed yaahc closed 3 years ago

dconnolly commented 3 years ago

The CI is pinned to 1.44.0 and build failing, on 1.49.0 (latest stable toolchain) it's passing.

str4d commented 3 years ago

@dconnolly

The CI is pinned to 1.44.0 and build failing, on 1.49.0 (latest stable toolchain) it's passing.

I believe that specific CI failure is related to https://github.com/zkcrypto/bellman/pull/57 (the upstream rustc breakage landed in 1.49 IIRC). It should be possible to similarly work around the issues here.

dconnolly commented 3 years ago

@ebfull @str4d I can't re-request a review from you in the github UI but 🙏

dconnolly commented 3 years ago

The clippy 'failure' if you do as it recommends it will not compile because:

‘z’: mismatched types
   expected reference `&<E as pairing::Engine>::Fr`
found associated type `<E as pairing::Engine>::Fr`
consider constraining the associated type `<E as pairing::Engine>::Fr` to `&<E as pairing::Engine>::Fr`
for more information, visit https://doc.rust-lang.org/book/ch19-03-advanced-traits.html [E0308]

dconnolly commented 3 years ago

@str4d @ebfull one more look? 🙏

dconnolly commented 3 years ago

@ebfull one more look por favor? 🙏

dconnolly commented 3 years ago

Yay, thank you!