Open HDauven opened 11 months ago
Upstream, we make use of Hash derive on Scalar.
Hash
Scalar
Scalar uses a custom PartialEq for constant-time comparison, but derives Hash, which leads to this Clippy warning downstream for us.
PartialEq
My proposed solution is to implement a custom Hash for Scalar that standardizes on the underlying values. A test is added to ensure consistency.
Upstream, we make use of
Hashderive onScalar.Scalaruses a customPartialEqfor constant-time comparison, but derivesHash, which leads to this Clippy warning downstream for us.My proposed solution is to implement a custom
HashforScalarthat standardizes on the underlying values. A test is added to ensure consistency.