zkcrypto / group

Elliptic curve group traits and utilities.
Other
91 stars 32 forks source link

Fix {Cofactor, Prime}Curve Mul bounds #22

Closed str4d closed 3 years ago

str4d commented 3 years ago

https://github.com/zkcrypto/group/blob/0a9a48ddaaa89042ac447801e67320c355e7c22a/src/prime.rs#L16 https://github.com/zkcrypto/group/blob/0a9a48ddaaa89042ac447801e67320c355e7c22a/src/prime.rs#L34 https://github.com/zkcrypto/group/blob/0a9a48ddaaa89042ac447801e67320c355e7c22a/src/cofactor.rs#L62 https://github.com/zkcrypto/group/blob/0a9a48ddaaa89042ac447801e67320c355e7c22a/src/cofactor.rs#L80-L83

These are supposed to be enabling multiplication of scalar references, but clearly they are HRTBing lifetimes that we never use. We should fix this!

Breaking change to traits, so requires a minor release.