zkcrypto / merlin

Composable proof transcripts for public-coin arguments of knowledge
MIT License
47 stars 16 forks source link

Allow transcript labels to come from non-Rust code #6

Open alinush opened 2 years ago

alinush commented 2 years ago

Addresses https://github.com/dalek-cryptography/merlin/pull/44.

This enables exporting a more versatile Bulletproof range proof verifier inside smart contracts (e.g., see Aptos and Sui).

Specifically, it allows smart contract developers to dynamically specify their domain separation tag (DST) in Transcript::new. This can be necessary in the smart contract setting where different smart contracts will verify proofs from different provers, each with an application-specific DST that might have been established years prior (e.g., think about verifying previously-computed Monero range proofs).

gregnazario commented 1 year ago

Hey @hdevalence could we get this reviewed and merged? Currently, any consumers using this patch have to apply it to themselves as well. Or is it @str4d who's the owner?

https://github.com/aptos-labs/aptos-core/issues/9340

gregnazario commented 1 year ago

@hdevalence or @str4d could you take a look at this?

gregnazario commented 11 months ago

@hdevalence @str4d ?

str4d commented 11 months ago

This is not my crate; @hdevalence has the publish bit.

hdevalence commented 11 months ago

Hey, sorry about the delayed follow-up. As the history indicates, I haven't had capacity to maintain the crate. Happy to turn over maintenance and crates.io ownership to someone who does.

alinush commented 11 months ago

Hey, sorry about the delayed follow-up. As the history indicates, I haven't had capacity to maintain the crate. Happy to turn over maintenance and crates.io ownership to someone who does.

@hdevalence, I am happy to adopt responsibility for the crate. I DM'd you my email address on Telegram.