zkemail / email-wallet

A smart contract wallet controlled using email
https://emailwallet.org
MIT License
131 stars 16 forks source link

Browser based email wallet connector #45

Open saleel opened 9 months ago

saleel commented 9 months ago

Allow dApp websites to easily integrate with EmailWallet by installing a JS script.

The JS script will

The ideal behaviour for a Uniswap UI would be

There is a MVP / WIP in connect-email-wallet branch.

Divide-By-0 commented 9 months ago

So what's missing in the browser-connector branch?

saleel commented 9 months ago

Its only a MVP that opens the mailto link for a target+call data. We want a script that others can include in their UI that implements the functionality in generic way - ideally confirming to https://eips.ethereum.org/EIPS/eip-1193

Divide-By-0 commented 4 months ago

This can also be done by a chrome extension that injects itself into login flows.

saleel commented 4 months ago

It would be better if users don't have to install any extensions. Dapps can install our JS SDK to interact with user's email wallet.

(both are kind of oauth as in "Sign in with Email Wallet", just differs in the flow/security model)

Anyway, implementation of browser-connector is not complete in this branch. There is a rough MVP, but there is no SDK that others can integrate yet. We can probably close this issue, and open a new one later based on which of the above approach we are going to take.