search

zkemail / email-wallet

A smart contract wallet controlled using email
https://emailwallet.org
MIT License
96 stars 15 forks source link

feat: Merge NFT Demo branch #68

Closed Bisht13 closed 2 months ago

SoraSuegami commented 3 months ago

https://github.com/zkemail/email-wallet/blob/feat/merge-nft-demo/packages/circuits/scripts/account_creation.ts#L11 I think you missed the circuits/helpers directory.

Bisht13 commented 3 months ago

https://github.com/zkemail/email-wallet/blob/feat/merge-nft-demo/packages/circuits/scripts/account_creation.ts#L11 I think you missed the circuits/helpers directory.

I removed it since it was no longer needed to be called from the relayer.

SoraSuegami commented 3 months ago

I understand. However, its codes are imported in the circuit tests. Could you make alternative functions to generate inputs for each circuit in the utils package and call them in the circuit tests?

Bisht13 commented 3 months ago

I understand. However, its codes are imported in the circuit tests. Could you make alternative functions to generate inputs for each circuit in the utils package and call them in the circuit tests?

I understand, so do you mean to expose the rust functions for circuit inputs as wasm bindings and use them to pass the tests?

SoraSuegami commented 3 months ago

Yes, but instead of exposing the functions as wasm, you can expose them as nodejs functions as neon. Please refer to the functions with the suffix "node" and the lib.rs in the utils package to know how to do that.

Bisht13 commented 3 months ago

Yes, but instead of exposing the functions as wasm, you can expose them as nodejs functions as neon. Please refer to the functions with the suffix "node" and the lib.rs in the utils package to know how to do that.

Sure, I'll expose them via neon and pass the tests.