search

zkemail / proof-of-twitter

Use https://twitter.prove.email to prove that you own a Twitter username, on-chain.
https://twitter.prove.email
MIT License
35 stars 22 forks source link

ci: Add Github actions #6

Closed isidroamv closed 11 months ago

isidroamv commented 12 months ago

@Divide-By-0 Please add the variable ALCHEMY_API_KEY in the project config and re-run the test. In addition, configure the project to block merges if the tests don't pass.

isidroamv commented 12 months ago

@Divide-By-0 Could you please configure the environment variable as the image below?

Screenshot 2023-11-29 at 14 22 02
Divide-By-0 commented 11 months ago

@isidroamv great! I will merge. We can greatly improve these tests, I added it to #9. For starters, we shuold rename the circuit tests to contract tests since that what they currently are!

unit tests only have this right now:

PASS tests/e2e-ui.test.ts (11.786 s)
  App.js
    ✓ should allow email and eth addr to be entered into inputs (1217 ms)
    ✓ should start with an enabled prove button and status should be 'not-started' (1217 ms)

These only test trivial UI functionality; they don't actually verify the download functionality or witness generation works -- can we add tests for those?