search

zkemail / zk-email-verify

Verify any text in any sent or received email, cryptographically and via only trusting the sending mailserver.
https://prove.email
MIT License
359 stars 77 forks source link

JS -> TS #131

Closed Divide-By-0 closed 11 months ago

Divide-By-0 commented 11 months ago

helpers/src/dkim has a bunch of JS. Replace that with TS.

Divide-By-0 commented 11 months ago

Imports complained in libraries that used this:

npx jest packages/circuits/tests/wallet.test.ts
 FAIL  packages/circuits/tests/wallet.test.ts
  ● Test suite failed to run

    node_modules/@zk-email/helpers/src/dkim/index.ts:2:30 - error TS7016: Could not find a declaration file for module './dkim-verifier'. '/Users/aayushgupta/Documents/.projects.nosync/zkemail/email-wallet-v0/node_modules/@zk-email/helpers/src/dkim/dkim-verifier.js' implicitly has an 'any' type.

    2 import { DkimVerifier } from "./dkim-verifier";
                                   ~~~~~~~~~~~~~~~~~
    node_modules/@zk-email/helpers/src/dkim/index.ts:3:31 - error TS7016: Could not find a declaration file for module './tools'. '/Users/aayushgupta/Documents/.projects.nosync/zkemail/email-wallet-v0/node_modules/@zk-email/helpers/src/dkim/tools.js' implicitly has an 'any' type.

    3 import { writeToStream } from "./tools";
Dhoni77 commented 11 months ago

Hi @Divide-By-0 I would like to work on this

Divide-By-0 commented 11 months ago

Sweet, feel free to make a PR @Dhoni77