Feat/fix select regex reveal - Githubissues

zkemail / zk-email-verify

Verify any text in any sent or received email, cryptographically and via only trusting the sending mailserver.

https://prove.email

MIT License

361 stars 77 forks source link

Feat/fix select regex reveal #214

Closed SoraSuegami closed 2 months ago

SoraSuegami commented 2 months ago

Description

This PR has the following three updates.

Fix the SelectRegexReveal template in circuits/utils/regex.circom to constrain that the given startIndex is less than maxArrayLen.
Add a note about an assumption that there should be only one consecutive sequence of non-zero bytes in in given to the SelectRegexReveal template.
Add new tests for the SelectRegexReveal template to circuits/tests/select-regex-reveal.test.ts.

Type of Change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

Checklist:

[x] I have discussed with the team prior to submitting this PR
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

SoraSuegami commented 2 months ago

Thank you for your review!