search

zkemail / zk-email-verify

Verify any text in any sent or received email, cryptographically and via only trusting the sending mailserver.
https://prove.email
MIT License
361 stars 77 forks source link

make long_div have signal-independent control flow #215

Closed Divide-By-0 closed 2 months ago

Divide-By-0 commented 2 months ago

This will help us with fast witness generation for the circuits. It's a fairly small improvement and change. Code here. Context:

image

I think this is a fairly small optimization anyways so it should be fine to comment out the whole code block for now. As a result, this is a very low priority task. It is important to verify that commenting this section does not affect correctness.

iYusuqe commented 2 months ago

@Divide-By-0 Hi, I would like to try this issue as my first OSS contribution.

Divide-By-0 commented 2 months ago

@Divide-By-0 Hi, I would like to try this issue as my first OSS contribution.

Hey! Thanks for your excitement. This is a fairly technical issue, and we got around it by just commenting out the relevant code block. I've attached a screenshot of that, so I no longer think this is a relevant issue. If you have significant background with ZK technology or mathematics and are excited about contributing here, I can point you to other things perhaps. If not, then I think there will likely find more approachable issues elsewhere! Screenshot_20240905_111856_Telegram

iYusuqe commented 2 months ago

@Divide-By-0 Thank you for your comment. I join PSE Core program and look for some issues to contribute to. I have started studying ZK recently but have some background of math. I continue to look for issues which I can try.