search

zkemail / zk-regex

A library to do regex verification in circom, adapted from the original zk-email. It additionally generates lookup tables for halo2-regex.
GNU General Public License v3.0
79 stars 27 forks source link

JS -> TS #18

Closed Divide-By-0 closed 8 months ago

Divide-By-0 commented 1 year ago

Convert our main files from JS to TS to make them safer and more readable.

SneakY-NickY commented 1 year ago

Hi, I'm here from https://github.com/zkemail/zk-regex/issues/24. Could you please assign me to this issue?

SneakY-NickY commented 1 year ago

I'm having issues installing dependencies for this project using yarn install. For some odd reason, it's trying to look for a module inside:

C:\Users\Martin\Desktop\zk-regex\node_modules\node_modules\cargo-cp-artifact\bin\cargo-cp-artifact.js

When the correct path should be:

C:\Users\Martin\Desktop\zk-regex\node_modules\cargo-cp-artifact\bin\cargo-cp-artifact.js

image

Any way I could possibly fix this myself?

SneakY-NickY commented 1 year ago

I've tried using npm/npm run as a replacement for yarn and everything seems to work. Still a bit weird since both should be doing the same thing afaik.

Divide-By-0 commented 1 year ago

@SneakY-NickY we've pushed some updates. let us know if the new build works! can we see your WIP PR?

SneakY-NickY commented 1 year ago

That's great to hear! I'll try it out tomorrow and show you the WIP as well. Also, sorry for a bit late reply 😅

SneakY-NickY commented 1 year ago

@SneakY-NickY we've pushed some updates. let us know if the new build works! can we see your WIP PR?

I've tried out the new build and unfortunately got the same errors 😢

Here's the WIP PR 😄 : https://github.com/zkemail/zk-regex/pull/29