Convert JS files to TS - Githubissues

zkemail / zk-regex

A library to do regex verification in circom, adapted from the original zk-email. It additionally generates lookup tables for halo2-regex.

GNU General Public License v3.0

76 stars 27 forks source link

Closed Divide-By-0 closed 7 months ago

Divide-By-0 commented 1 year ago

Files include:

Tejasp2003 commented 1 year ago

i would like to work on this

Divide-By-0 commented 1 year ago

@Tejasp2003 feel free to take it, and make a PR!

AnmolSirola commented 1 year ago

@Divide-By-0 Is anyone still working on this pr ?

Divide-By-0 commented 1 year ago

@Divide-By-0 Is anyone still working on this pr ?

Nope, you're free to and make a PR!

SneakY-NickY commented 11 months ago

Is this still a relevant issue? I would like to work on this.

Divide-By-0 commented 11 months ago

Hey, you're free to take it. Lexical.js in zk regex is still JS.

SneakY-NickY commented 11 months ago

Great, could you please assign this issue to me?

SoraSuegami commented 11 months ago

Hi! I am one of the developers of zk-regex. Thank you very much for your help!

Could you convert regex.js (modification of lexical.js) and gen_circom.js (modification of gen.py) in zk-regex to TS instead of JS files in zk-email-verify? https://github.com/zkemail/zk-regex/tree/main/packages/compiler/src

We are moving all of the regex-related codes to zk-regex repo.

SneakY-NickY commented 11 months ago

Divide-By-0 commented 11 months ago

Sure thing! Is the issue zkemail/zk-regex#18 related to this?

Yes, that is the same issue (we should deprecate this current issue zkemail/zk-regex#24 in favor of that one, now that the regex code has moved).

SneakY-NickY commented 11 months ago

I left a comment in there so you can assign me to it.