search

zkemail / zk-regex

A library to do regex verification in circom, adapted from the original zk-email. It additionally generates lookup tables for halo2-regex.
GNU General Public License v3.0
76 stars 27 forks source link

Updated TS gen_circom to support latest commits #34

Closed SneakY-NickY closed 9 months ago

SneakY-NickY commented 10 months ago

Updated TypeScript version of gen_circom.js to support commits pushed into the main branch

Divide-By-0 commented 10 months ago

Hey! There are no tests right now so it's hard for me to gauge if this broke anything, can you add a test that runs this file on a few regexes and checks if it compiles?

SneakY-NickY commented 10 months ago

This PR is going to merge with branch in https://github.com/zkemail/zk-regex/pull/31 Perhaps it would be a good idea to merge this one first and see if tests in https://github.com/zkemail/zk-regex/pull/31 pass? 😄 Not exactly sure how to run a test for this PR as I've not done it before 😅

Divide-By-0 commented 9 months ago

if you can just add a simple jest file that generates a circom regex file, then tests that it compiles correctly, that would be ideal. But that works, let's add it to #31.