zkemail / zk-regex

A library to do regex verification in circom, adapted from the original zk-email. It additionally generates lookup tables for halo2-regex.
GNU General Public License v3.0
79 stars 27 forks source link

Fixing email address and domain regexes. #68

Closed SoraSuegami closed 2 months ago

SoraSuegami commented 2 months ago

This PR fixes bugs that the current regexes for email address and domain cannot capture an address containing "@" in the name part, e.g., "alice@gmail.com@dummy.com". However, the email_domain_regex.circom circuit cannot capture such an address correctly due to limitation of the circuit construction, so it exposes all substring after "@", e.g., "gmail.com@dummy.com" is output as the domain of "alice@gmail.com@dummy.com".

Bisht13 commented 2 months ago

LGTM