zkfan / tungsten-replicator

Automatically exported from code.google.com/p/tungsten-replicator
0 stars 0 forks source link

Tungsten Installer should be able to pass options to configure and configure-service #137

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
1. To which tool/application/daemon will this feature apply?

tungsten-installer

2. Describe the feature in general

When setting parallel replication or multiple master replication, we need to 
pass options to configure and configure-services, possibly without having to 
restart the replicator after the installation.

3. Describe the feature interface

the installer should have two new options, which can be entered more than once
--configure=name=value
--configure-service=name=value
(where "name" is a given available option for configure or configure-service)

4. Give an idea (if applicable) of a possible implementation

There are two ways of achieving the goal.
a) tungsten-installer will collect the options and pass them to configure and 
configure-service
b) both configure and configure-service will be able to get options from 
environment variables
e.g.
export INSTALL_CONFIGURE=key=value,key=value,key=value
export INSTALL_CONFIGURE_SERVICE=key=value,key=value,key=value
In this case, tungsten installer will just have to set the appropriate 
variables before invoking the script.

5. Describe pros and cons of this feature.

5a. Why the world will be a better place with this feature.

Installation with only one line will become feasible, even for complex setups.

5b. What hardship will the human race have to endure if this feature is
implemented.

If the feature is implemented as ability to get options from environment 
variables, there is the risk that variables may be left already set from 
previous installations, and create a hard-to-detect bug.

Original issue reported on code.google.com by g.maxia on 29 Jun 2011 at 11:06

GoogleCodeExporter commented 9 years ago
I've added the script support for this as just the '--configure' option.  The 
script will automatically use it where necessary so there is no need to have a 
distinction between '--configure' and a '--configure-service'.

I am going to create a new issue to cover documenting the difference between 
'--property' and '--configure'.  We also need to document what are valid items 
to specify in '--configure'.

Original comment by jeffm...@gmail.com on 6 Jul 2011 at 1:47