properties file uses hardcoded file names for backup and other

[GoogleCodeExporter]

There are several hard coded file names in the properties file.

replicator.backup.agent.lvm.dataDir=/var/lib/mysql
replicator.backup.agent.lvm.snapshotMount=/mnt/snapshots
replicator.backup.agent.lvm.mysqlStart=/etc/init.d/mysqld start
replicator.backup.agent.lvm.mysqlStop=/etc/init.d/mysqld stop
replicator.resourceLogDir=/var/log/mysql
replicator.storage.agent.fs.directory=/mnt/backups

These files names should either
* associated to an option in the installer
or 
* created as a sub-directory of one of the known paths that are defined in the 
installer.
or 
* left blank

Original issue reported on code.google.com by g.maxia on 7 Jun 2011 at 1:04

[GoogleCodeExporter]

Original comment by jeffm...@gmail.com on 20 Jun 2011 at 8:29

• Changed state: Started

[GoogleCodeExporter]

I would like to commit these changes to the sample configuration files.  I 
removed the default backup method and backup storage directory.  If these items 
are configured by the script the user will need to provide that information 
anyway.

Are these changes too agressive?

Original comment by jeffm...@gmail.com on 3 Jul 2011 at 10:24

• Changed state: Accepted

Attachments:

• conf-samples.diff

[GoogleCodeExporter]

No problem with ditching the lvm.

The default backup method should remain mysqldump (or pg_dump).

The storage agent default should remain, and the 
replicator.storage.agent.fs.directory should default to a directory under 
--home-directory

Original comment by g.maxia on 4 Jul 2011 at 2:01

[GoogleCodeExporter]

I compromised.  I took the backup storage directory out of the sample file but 
I've ensured that it is filled in by default when you use the configure script. 
 I also added a 'backup-directory' option to the tungsten-installer script.

Original comment by jeffm...@gmail.com on 4 Jul 2011 at 3:37

• Changed state: Fixed
• Added labels: FixedIn-2.0.4

[GoogleCodeExporter]

There is no --backup-directory in the installer

ERROR >> invalid option for --direct: 
--backup-directory=/home/tungsten/newinst/bk

Original comment by g.maxia on 5 Jul 2011 at 7:16

• Changed state: Started

[GoogleCodeExporter]

I have confirmed that this is in build 157.  Could you post the manifest for 
your build?

Original comment by jeffm...@gmail.com on 5 Jul 2011 at 11:08

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Still some problems

./tools/tungsten-installer \
    --direct \
    --master-host=r1 \
    --slave-host=r4 \
    --master-user=tungsten \
    --slave-user=tungsten \
    --master-password=secret \
    --slave-password=secret \
    --service-name=Castor \
    --thl-port=21124 \
    --rmi-port=10000 \
    --channels=5 \
    --home-directory=$TUNGSTEN_BASE \
    --backup-directory=$TUNGSTEN_BASE/bk \
    --svc-parallelization-type=disk \
    --property=replicator.global.buffer.size=100 \
    --start-and-report

ERROR >> Argument parsing failed: undefined method `count' for 
["replicator.global.buffer.size", "100"]:Array

$ cat .manifest
# Build manifest file
DATE: Tue Jul  5 05:24:26 UTC 2011
RELEASE: tungsten-replicator-2.0.4-157
USER ACCOUNT: hudson
BUILD_NUMBER: 157
BUILD_ID: 157
JOB_HAME: Build Replicator Branch-2.0 Google
BUILD_TAG: hudson-Build Replicator Branch-2.0 Google-157
HUDSON_URL: http://cc.aws.continuent.com/
SVN_REVISION: 294
HOST: ip-10-251-90-63
SVN URLs:
  https://tungsten-replicator.googlecode.com/svn/trunk/commons
  https://tungsten-replicator.googlecode.com/svn/trunk/fsm
  https://tungsten-replicator.googlecode.com/svn/trunk/replicator
  https://tungsten-replicator.googlecode.com/svn/trunk/replicator-extra
  https://bristlecone.svn.sourceforge.net/svnroot/bristlecone/trunk/bristlecone
SVN Revisions:
  commons: Revision: 294
  fsm: Revision: 294
  replicator: Revision: 294
  replicator-extra: Revision: 294
  bristlecone: Revision: 105

Original comment by g.maxia on 5 Jul 2011 at 11:50

[GoogleCodeExporter]

I pasted the wrong error in the previous comment. Here is the one about backup

#####################################################################
# There are errors with the values provided in the configuration file
#####################################################################
---------------------------------------------------------------------
ERROR >> Dataserver r1_3306: Backup permanent shared storage
ERROR >> > Message: Value must be a valid filename
ERROR >> > Config Key: dataservers.r1_3306.repl_backup_storage_dir

Original comment by g.maxia on 5 Jul 2011 at 11:52

[GoogleCodeExporter]

The script was validating the backup directory for a server where backups were 
not configured.  Updating the script to not validate the backup directory in 
that case.

Original comment by jeffm...@gmail.com on 5 Jul 2011 at 12:36

• Changed state: Fixed