Closed GoogleCodeExporter closed 9 years ago
I agree with you, it's a good idea.
Original comment by angelo.z...@gmail.com
on 21 Feb 2013 at 8:48
for the moment working on patch. Test case for 225 will be modified to reach
and this case
Original comment by ruslancu...@gmail.com
on 21 Feb 2013 at 8:49
Found new bug. if List is declared as: List<String> someStringList, it don't
appear in fields list. Also, If in the dataModel tree some field is List, it is
not declared as list in fields.xml.
Original comment by ruslancu...@gmail.com
on 21 Feb 2013 at 9:29
Please create a new bug please for that and if you have time please provide us
a patch.
I think you will find a lot of problem with serializer because it manages only
simple case.
Original comment by angelo.z...@gmail.com
on 21 Feb 2013 at 9:38
It will be a bit complicated to manage these bugs separately, because with this
new bugs, it is imposible to implement new feature.
Original comment by ruslancu...@gmail.com
on 21 Feb 2013 at 9:40
Ok I understand, we must commit step by step your patch. I will try do that
asap.
Original comment by angelo.z...@gmail.com
on 21 Feb 2013 at 9:42
ok.. don't speed up the things please, let's to be sure that these patched will
not affect other modules.
Original comment by ruslancu...@gmail.com
on 21 Feb 2013 at 9:44
A question related to FieldsMetadataSerializer. For the momment serializer
accept only Class types, and what about java primitive types? why tthese types
are ignored? and should be primitive types be ignored?
Original comment by ruslancu...@gmail.com
on 22 Feb 2013 at 8:04
Here I attach a patch with solution and new junit test.
With this patch Serializer will manage complex types.
this version of serizlizer will scan whiole tree of datamodel, and if it will
detect some list inside, it will mark it as list. Also this patch prepare
Abstract serializer to solve issue 180. Unfortunately solution for issue 225
was a locally quick fix, and it doesn't permit scanning for complex data
models, as it use vizited class types to detect cycled in tree scanning. With
this patch, detecting of the loops is done by checking field path's, instead of
visited class, as we can have 2 or more fields with same calss type, as we can
have same class as parent for other.
Original comment by ruslancu...@gmail.com
on 22 Feb 2013 at 8:14
Attachments:
merged in commit 679637e01c1acc6e0eacec656a9f9efcb4f50e51
Thanks for your contribution !
Original comment by pascal.leclercq
on 25 Feb 2013 at 8:34
Original issue reported on code.google.com by
ruslancu...@gmail.com
on 21 Feb 2013 at 7:44