zkitter / zkitterd

MIT License
10 stars 2 forks source link

chore: bump libs, fix gh test action #8

Closed sripwoud closed 2 years ago

sripwoud commented 2 years ago

1. Bump Libs

Upon seeing a recurrent error in the CI test pipeline, I started investigating it.

npm ERR! Could not install from "node_modules/circom-helper/node_modules/snarkjs/blake2b-wasm@git+https:/github.com/jbaylina/blake2b-wasm.git" as it does not contain a package.json file.

It was probably not the culprit, but I thought node 12 seemed a bit low/outdated.
So I tried with lts (16.17.0).
Which triggered another error when installing the deps:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: autism-node@1.0.0
npm ERR! Found: webpack@4.46.0
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^4.44.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^5.0.0" from node-loader@2.0.0
npm ERR! node_modules/node-loader
npm ERR!   dev node-loader@"^2.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/r1oga/.npm/eresolve-report.txt for a full report.

So I bumped webpack to 5. Next I had to fix a few breaking changes in the webpack config files.
Other errors were raised during the install step, so I ended re generating a new package-lock.json.
If that is too brutal/risky, I can try to bump individual deps more progressively.

After all these steps, the npm install step of the GH action succeeds.

2. GH test action

The PR also fixes the test GH actions but doesn't fix the test themselves (some of them are failing). It just allows the test step of the workflow to at least execute. It seems there are still some issues as the tests execution is stuck. Not sure why (maybe open handles?). See job

Test plan