zkmkarlsruhe / ofxTensorFlow2

TensorFlow 2 AI/ML library wrapper for openFrameworks
Other
113 stars 17 forks source link

git submodule update not working on macOS #35

Closed stephanschulz closed 1 year ago

stephanschulz commented 1 year ago

I get the following access rights issue when following the Quick Start guide. Do I need to fork the add-on first?

stephanschulz@Stephans-Komputer ofxTensorFlow2 % git submodule update --init --recursive
Cloning into '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:serizba/cppflow.git' into submodule path '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow' failed
Failed to clone 'libs/cppflow'. Retry scheduled
Cloning into '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:serizba/cppflow.git' into submodule path '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow' failed
Failed to clone 'libs/cppflow' a second time, aborting
danomatika commented 1 year ago

We don’t have control of that. It could just have been a hiccup on the github servers and when it happens, I usually wait and try again later.

enohp ym morf tnes

Dan Wilcox danomatika.com robotcowboy.com

On Feb 23, 2023, at 10:12 PM, Stephan Schulz @.***> wrote:

 I get the following access rights issue when following the Quick Start guide. Do I need to fork the add-on first?

@. ofxTensorFlow2 % git submodule update --init --recursive Cloning into '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow'... @.: Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. fatal: clone of @.:serizba/cppflow.git' into submodule path '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow' failed Failed to clone 'libs/cppflow'. Retry scheduled Cloning into '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow'... @.: Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. fatal: clone of @.***:serizba/cppflow.git' into submodule path '/Applications/of_v20220530_osx_release/addons/ofxTensorFlow2/libs/cppflow' failed Failed to clone 'libs/cppflow' a second time, aborting — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

danomatika commented 1 year ago

Is this resolved by now?

stephanschulz commented 1 year ago

I just tried it again and still gives me the same error. But downloading the cpp directly and placing is in the cpp folder works. Screen Shot 2023-02-27 at 2 19 52 PM

danomatika commented 1 year ago

Can you try the following?

  1. edit .gitmodules and change: git@github.com:serizba/cppflow.git -> https://github.com/serizba/cppflow.git
  2. run:
    git submodule deinit -f libs/cppflow
    git submodule update --init --recursive
    git submodule sync
stephanschulz commented 1 year ago

thanks for continuing to pay attention to this :)

I edited the .gitmodules. I do not sure what to do with "2. run"

calling git submodule deinit -f libs/cppflow produces an error. see screenshot

Screen Shot 2023-03-01 at 3 51 50 PM

danomatika commented 1 year ago

"git run" is not a command. The "2. run" in my previous post is an instruction to run the code which is quoted underneath in the Terminal.

Looking at your Terminal output, you indeed ran git deinit successfully once. The error comes from running it again when the submodule has already been deinitialized. To continue, run the next two commands:

git submodule update --init --recursive
git submodule sync
danomatika commented 1 year ago

Also, if you manually copied the files in, you may need to manually remove the folder before running update.

danomatika commented 1 year ago

I think I know the issue. I bet the system you are cloning on does not have SSH keys which are copied to your Github account. The submodule is using git@github.com so it will try to use SSH for authentication. In any case, I will update the submodule url to https and make a 1.4.1 release.

stephanschulz commented 1 year ago

I will try the rest of the commands in a few days when I am back at home.

stephanschulz commented 1 year ago

yes this works. thank you

danomatika commented 1 year ago

Thanks for the confirmation. Now fixed in main and 1.4.1 tag.

danomatika commented 1 year ago

Thanks for confirming.