zkmopro / mopro

Making client-side proving on mobile simple.
https://zkmopro.org
Apache License 2.0
131 stars 35 forks source link

mopro deps did not finish successfully #119

Closed ChihChengLiang closed 8 months ago

ChihChengLiang commented 8 months ago

I followed the README steps, run mopro deps, and got the following error messages.

$  mopro deps 
Installing required dependencies
Target x86_64-apple-ios already installed, skipping.
Target aarch64-apple-ios already installed, skipping.
Target aarch64-apple-ios-sim already installed, skipping.
Target aarch64-linux-android already installed, skipping.
Target armv7-linux-androideabi already installed, skipping.
Target i686-linux-android already installed, skipping.
Target x86_64-linux-android already installed, skipping.
arkzkey-util already installed, skipping.
  Installing mopro-ffi v0.1.0 (/Users/liangcc/projects/repos/mopro/mopro-ffi)
    Updating git repository `https://github.com/oskarth/wasmer.git`
    Updating crates.io index
    Updating git repository `https://github.com/arkworks-rs/circom-compat.git`
   Compiling ark-zkey v0.1.0 (/Users/liangcc/projects/repos/mopro/ark-zkey)
   Compiling mopro-core v0.1.0 (/Users/liangcc/projects/repos/mopro/mopro-core)
The following warnings were emitted during compilation:

warning: mopro-core@0.1.0: Preparing circuits...
warning: mopro-core@0.1.0: BUILD_CONFIG_PATH not set. Using default configuration.

error: failed to run custom build command for `mopro-core v0.1.0 (/Users/liangcc/projects/repos/mopro/mopro-core)`

Caused by:
  process didn't exit successfully: `/Users/liangcc/projects/repos/mopro/target/release/build/mopro-core-6d2fd0d2707bf95c/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=BUILD_CONFIG_PATH
  cargo:warning=Preparing circuits...
  cargo:warning=BUILD_CONFIG_PATH not set. Using default configuration.

  --- stderr
  Error: Required files for building the circuit are missing. Did you run `mopro prepare`?

  Location:
      mopro-core/build.rs:189:20
warning: build failed, waiting for other jobs to finish...
error: failed to compile `mopro-ffi v0.1.0 (/Users/liangcc/projects/repos/mopro/mopro-ffi)`, intermediate artifacts can be found at `/Users/liangcc/projects/repos/mopro/target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
-e 
Script did not finish successfully!
Unable install dependencies.

commit: 0918194e3b46852b60cd124043018f36ec89bef8

oskarth commented 8 months ago

I tried a fresh check-out and removed arkzkey-util but unable to reproduce this. Not sure why, think mopro-core gets triggered to build differently depending on deps installed.

If I manually trigger cargo run in mopro-core I can reproduce the error. I think this should fix it: https://github.com/oskarth/mopro/pull/121 (Android failing for some reason but iOS works)

ChihChengLiang commented 8 months ago

I can confirm #121 fixed my local build Thanks for the fix!