search

zkmopro / mopro

Making client-side proving on mobile simple.
Apache License 2.0
103 stars 28 forks source link

Publish ark-zkey module as a library on Crate.io #131

Closed seemenkina closed 1 month ago

seemenkina commented 2 months ago

Problem

The mopro project currently works under a patch to the wasmer library. This patch causes a conflict and overrides dependencies when using mopro as a submodule if wasmer is also used in the other project. At the same time ark-zkey module does not require a wasmer, but because it is part of the mopro project you have to connect the whole project.

Suggested solution

To address this issue, I suggest isolating ark-zkey module as a library and publishing it separately. It provides easy use of its functionality to everyone.

rymnc commented 2 months ago

cc: @vivianjeng as per recommendation from Oskar :)

vivianjeng commented 1 month ago

sorry for the late reply let me know if it works for you https://crates.io/crates/ark-zkey

seemenkina commented 1 month ago

Hey @vivianjeng, thank you so much! I'll check in a while

cc: @rymnc

oskarth commented 1 month ago

Seems to have been fixed, https://github.com/vacp2p/zerokit/pull/251

Thanks everyone!