zkmopro / mopro

Making client-side proving on mobile simple.
Apache License 2.0
103 stars 28 forks source link

Integrating gpu exploration app #137

Closed FoodChain1028 closed 1 month ago

FoodChain1028 commented 1 month ago

The gpu exploration app is made using mopro init. This app explores the msm functions that we implements in mopro-core and test in rust, and can be run on simulator and mobile.

vivianjeng commented 1 month ago

Can you update the mopro-cli and check your uniffi-bindgen version? I got diffs in mopro.swift

FoodChain1028 commented 1 month ago

Can you update the mopro-cli and check your uniffi-bindgen version? I got diffs in mopro.swift

Hi @vivianjeng, my current uniffi-bindgen version is 0.25.3 and I updated mopro-cli now. Can you check again?

vivianjeng commented 1 month ago

the mopro test works for me. Thank you. can you check your uniffi-bindgen --version in the terminal? it is still different.

FoodChain1028 commented 1 month ago

the mopro test works for me. Thank you. can you check your uniffi-bindgen --version in the terminal? it is still different.

uniffi-bindgen --version
uniffi-bindgen 0.25.3

mine is 0.25.3

Is the difference about the file keyword in front of each statement?

private extension Data {
    init(rustBuffer: RustBuffer) {
        // TODO: This copies the buffer. Can we read directly from a
        // Rust buffer?
        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
    }
}

and

fileprivate extension Data {
    init(rustBuffer: RustBuffer) {
        // TODO: This copies the buffer. Can we read directly from a
        // Rust buffer?
        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
    }
}
vivianjeng commented 1 month ago

@FoodChain1028 yes mine is also 0.25.3 does it happen to you if you run mopro build --platforms ios in the gpu-benchmark dir?

FoodChain1028 commented 1 month ago

@vivianjeng
I checked with the binding file generated from mopro and found that the difference. And no, after I ran mopro build --platforms ios, the result came out was the one in gpu-exploration-app (without keyword file).