zkmove / halo2-verifier.move

A set of tooling of halo2 circuits verification in Move environments
Apache License 2.0
16 stars 4 forks source link

Verifier api #59

Closed nanne007 closed 9 months ago

nanne007 commented 9 months ago

The pr mainly add the verifier api, a separate move project.

and to make protocol storable, I did an optimization, abstract a field pool whose job is to store all fields, so we will not serialize duplicate fields, saving more spaces here.

zhmoly commented 9 months ago

In protocol.move, I can see only this line which use Element fun deserialize_commitment_list(bytes: &vector): vector<Element> {

Should use vector in this line too? If then, maybe no need to import Element in protocol.move

nanne007 commented 9 months ago

In protocol.move, I can see only this line which use Element fun deserialize_commitment_list(bytes: &vector): vector {

Should use vector in this line too? If then, maybe no need to import Element in protocol.move

It's used to check the format of input data. remove the import of Element from protocol.move is not our goal here.