chore: fix ci - Githubissues

zkochan / packages

Zoltan Kochan's npm packages

MIT License

99 stars 26 forks source link

chore: fix ci #202

Open bluwy opened 2 months ago

bluwy commented 2 months ago

Ensures test only run if the node version matches from engines.node
Since macos-latest now points to macos-14, it can't installed node<=14 in arm architecture. While macos-13 could be used instead, I figured maybe we could remove it altogether for now since it's rare for some to use them with macos, and windows/ubuntu to probably capture most case.

bluwy commented 3 weeks ago

@zkochan Sorry to bother you, but I hope you can take a look at this PR and the rest I've sent recently around preferred-pm and which-pm. This PR fixes the CI which should unblock the fails happening in the other PRs.

I noticed you've merged https://github.com/zkochan/packages/pull/195, but this PR allows node 12 to be tested still on packages that still supports it, and fixes the macos fail