search

zkokaja / Brewlet

The missing menulet for brew.sh: keeping your packages up-to-date, and your system secure.
BSD 2-Clause "Simplified" License
438 stars 13 forks source link

Prevent Repeating Upgrade Notifications #3

Closed cmpadden closed 4 years ago

cmpadden commented 4 years ago

Only notify the end-user when the upgrade status transitions from having no updates, to having updates available. This prevents repeating notifications on the hour if upgrades are not applied.

zkokaja commented 4 years ago

Thanks! This looks great. I'm wondering if a better condition would be if it only prevented notifications if the number of packages remained the same. That way, if more packages are available, then the user would still get notified and a chance to look at them. Thoughts?

cmpadden commented 4 years ago

I like the idea of using the count much more; I've made the changes.

I've also added some comments with some questions I have.

zkokaja commented 4 years ago

Great! Tested and merged.