zkopru-network / blind-find

A peer-to-peer network allowing private peer search proposed by Barry Whitehat and Kobi Gurkan.
https://ethresear.ch/t/blind-find-private-social-network-search/6988
13 stars 2 forks source link

Sometimes tests for `ProofOfDiscreteLog` fails #2

Closed mhchia closed 3 years ago

mhchia commented 3 years ago

Tests for ProofOfDiscreteLog fails sometimes, roughly once in 5 runs. My gut feeling is probably due to the wrong modulus of scalars. Outside the circuits, we modulo the subgroup order q, but inside modular operations are done with the prime p. It fails sometimes probably just because secrets are generated randomly. However, I still need to double-check to confirm the issue.

mhchia commented 3 years ago

Fixed.