zkp-ld / rdf-canon

A Rust implementation of the RDF Dataset Canonicalization algorithm version 1.0 (RDFC-1.0) compatible with Oxigraph and Oxrdf. The purpose of this implementation is only to understand and evaluate the specification and is not intended for production use.
MIT License
9 stars 1 forks source link

PyO3?? #21

Open sneakers-the-rat opened 8 months ago

sneakers-the-rat commented 8 months ago

Hello! I was wondering if someone had already done this, bc I was interested in doing it myself, and this looks great!!!

Im curious if you would be interested in a contribution of PyO3 bindings? The current graph canonicalization algo in rdflib is dreadfully slow, and so if we make python bindings to a rust version we could, well, make it a lot faster!

Still scoping out what it would take to make it compatible with rdflib, but if youre interested I could start drafting a PR?

yamdan commented 8 months ago

Hi! Thank you for your suggestion. While I am not very knowledgeable or experienced with PyO3, I would warmly welcome any pull requests. As an aside, please be aware that my implementation may not achieve the expected performance yet, as it has not been sufficiently optimized.