Implement & Fixes URL Cards

zkparty / trusted-setup-frontend

The KZG Ceremony web browser implementation

https://ceremony.ethereum.org

229 stars 66 forks source link

Implement & Fixes URL Cards #113

Closed CarlBeek closed 1 year ago

CarlBeek commented 1 year ago

Resolves #107 by:

Fixing the og-image URL because Open Graph doesn't support relative links.
Reduces duplicate/unnecessary Open Graph properties
Deduplicates Twitter card properties as they can be inherited from Open Graph (See Twitter Dev docs)

Review required by @tvanepps:

[x] Updates description to "Help secure Danksharding (EIP-4844) by participating now in the Ethereum KZG Summoning Ceremony."
[x] Image updated to the one created in #107 but it had to be cropped & resized to fit. @tvanepps please can you re-export in 1200x630 resolution as the new version's proportions look a bit ugly.

tvanepps commented 1 year ago

let me know if this works, this uses the 1200x630 ratio

preview card_carl

tvanepps commented 1 year ago

"Help secure Danksharding (EIP-4844) by participating now in the Ethereum KZG Summoning Ceremony."

as we talked about earlier, i think it's probably best to include "scaling/scale", as this is ultimately what it will do! how's this? (open to suggestions) depends how much space is available under the card

Help scale Ethereum by participating in the KZG Summoning Ceremony! Help scale Ethereum by contributing randomness/entropy to the KZG Summoning Ceremony! Add your randomness to the KZG Summoning Ceremony to help scale Ethereum!

CarlBeek commented 1 year ago

Thanks @tvanepps! Ended up going with:

"Add your randomness to the KZG Summoning Ceremony to help scale Ethereum!"

@NicoSerranoP or @glamperd ready for review/merge when y'all have a moment