zkparty / trusted-setup-frontend

The KZG Ceremony web browser implementation
https://ceremony.ethereum.org
229 stars 66 forks source link

Update intl URL support #136

Closed wackerow closed 1 year ago

wackerow commented 1 year ago

Description

Recently the ceremony and contributions pages were updated to open in new tabs. With this, the language selection from the landing page was lost, and the new pages opened with English even if the user changed languages.

Approach to fixing in this PR

Screenshots

image
NicoSerranoP commented 1 year ago

Thank you for noticing this problem. I check out this PR and realized that it was not working in the lobby/contributing/complete pages. We were not having this issue before and I realized it was because the LanguageSelector element was not being loaded in the header. I make it load, used display=none to hide it and the selected language was persistent accross all pages.

137 replaces this PR