zkparty / trusted-setup-frontend

The KZG Ceremony web browser implementation
https://ceremony.ethereum.org
229 stars 66 forks source link

UI Comments on the Records Page #95

Closed tvanepps closed 1 year ago

tvanepps commented 1 year ago
    • [x] elsewhere in the copy we use "Contribution" not "Record". in the past we discussed those and "Transcript". we should pick one and be consistent, I dont have a strong preference, could even be "Contribution Records" or "Contribution Transcript" for the title. If needed, the FAQ should be updated to reflect our decision here.
    • [x] What is the sequencer address and why do users need to see it here?
    • [x] the search field has too many components and cuts off whatever appears after "#". Either we need to remove that last element, widen the search bar, or shorten some of the other text elements. Also, somewhere we had discussed not using ENS bc it might change in the future - is that still the case?
    • [x] what is "Seq. #"? if sequence, it's not clear bc we also use Sequencer in the docs and specs. i think it should just be "#" or nothing, it's pretty clear what that column refers to
    • [x] why is the word "Specification" here? if not needed it should be removed. in the "view" modal, it's called "Participant ID", which might be better for consistency
    • [x] i should be able to click anywhere within the red box to access the "Contribution Details" modal that is accessible when clicking "View". when a cursor is within the red box, can we do a very simple hover animation like we have for other buttons and turn the cursor into a hand? if this can be done, we can remove the "Details/ view" column entirely. otherwise the "view" is redundant. (not a strong opinion if there is good reason to keep it)
    • [x] Why would a user need to click into the individual "PoT Pubkeys" from here? can we move this expand interaction to the modal that comes when clicking "view"? Also, can we put the 4 identicons in a horizontal line instead of 2X2 to compress records vertically? (if it stays as a 2X2, thespace between the top and the bottom identicons should be the same)
    • [x] why is there a horizontal scroll here? should not appear at 100% zoom
    • [x] how is it possible there are two contributions from stefan via github? i thought we were filtering for duplicate contributions from the same participant.

image

tvanepps commented 1 year ago

Generally, it's hard to know what this modal is telling users - should they be saving the info locally? we should consider adding some tooltips next to each header 🛈 that expands with info on hover, or just include all info next to the header by default.

    • [ ] the "x" appears differently when next to text vs a number
    • [x] "Pot" is not useful. Should either say "Powers of Tau" or be omitted
    • [x] Can we reproduce the identicons here next to their pubkey to show the link? if we do this, make sure the image is aligned with the left side of the header text above
    • [x] "Sequence #" (or whatever it's changed to on the screen before) should also appear on this modal below "Contribution Details" - possibly with ←→ toggle so users can cycle through many contributions without having to exit and reenter this modal every time. the toggle arrows are a lower priority tho

image

tvanepps commented 1 year ago
    • [x] There should be a an action suggestion for each of the numbers/ arrow when i hover it should change to the hand cursor and be underlined/ drop shadowed
    • [x] the footer is just a little too large. can we shrink it vertically to about the size of the red rectangle?
    • [x] We will have 2 audit reports, maybe there needs to be separate links to the Implementation report and the sequencer audit? or just remove this link and send users to the documentation where they can find both image
NicoSerranoP commented 1 year ago

Hey @tvanepps! Almost finish here 🚀. Meanwhile, I add some comments to your observations

  1. The sequencer signs and sends a receipt after the participant uploads the contribution. We can use the sequencer address to confirm that the receipt was truly coming from the sequencer itself.

  2. We were thinking on showing the participants their 4 PoT pubkeys right away because these are like their unique fingerprints in the contribution. We should the identicons in the completed contribution modal and here. The color combination make them unique and it is a nice way to showing how every single contribution is unique in the list.

7.1. I voted on leaving the identicons outside and inside the modal. 7.2. We can put them in a 4x1 array

  1. Right now the sequencer is in development mode and it is accepting multiple contributions from the same participant

  2. The first audit report was related to the Small Powers of Tau implementation. We decided to swap that implementation with the sequencer crypto library (which was already audited in the second report). I feel we can leave only one Audit Report link to the Sigma Prime audit PDF

tvanepps commented 1 year ago

thanks for the clarifications/info. these generally make sense

  1. we probably need a guide for how users should verify contributions. see the namada trusted setup "Verify Contribution" button, instructions hosted on github. what would verification look like for our ceremony? eg. hosted on the interface itself vs. or another repo, what steps would the user need to complete, etc

  2. makes sense. we might need a tooltip for this to explain why unique identicons are important / what they signify

  3. makes sense, carl also explained why this is the case. we should definitely start with a clean slate when the time comes

  4. sounds good, we will need to upload the completed report to the kzg repo when it's produced and point to that one

PlasmaPower commented 1 year ago

One other UI consideration: If you're on e.g. the second page of contributions, and then you search for a particular address, it won't show up until you click the "1" at the bottom to jump back to the first page, which confused me at first.

glamperd commented 1 year ago

image

The Signed by field is confusing. It shows the identity of the contributor, but it's under the title of 'Sequencer Acknowledgement' I feel it should show the sequencer's address, as proof that the real sequencer signed the receipt.

The contributor identity could also be shown on the page, but in a different place so it's clear it belongs to the contributor, not the sequencer.