search

zkrising / Tachi

A Cutting-Edge, Modular Score Tracker
https://tachi.ac
132 stars 58 forks source link

Reverting an import for a chart hides all your scores of that chart #1129

Closed nyairobi closed 3 months ago

nyairobi commented 4 months ago

Steps to reproduce

  1. Have at least one existing score on a chart.
  2. Make an import with a new score of that chart.
  3. Revert that import.

Expected behavior

Only the new score gets reverted.

Actual behavior

It appears as if I haven't ever played the chart, and my NaiveRating drops down (even though it's only supposed to go up). This is my real graph for Ongeki:

Screenshot_20240718_004513

Furthermore, adding another import for that chart fixes it.

Minimal example

  1. Import test1.json.
  2. Import test2.json.
  3. Revert test2.
  4. Go here and note you're not there.
  5. Import test3.json.
  6. Go back to the chart page and note that the score from test1 has re-appeared.
zkrising commented 4 months ago

I suspect this is an issue with the PB logic somehow. Maybe the PB on the chart is getting removed.