zkrising / Tachi

A Cutting-Edge, Modular Score Tracker
https://tachi.ac
132 stars 58 forks source link

versioning and isAvailable should be pulled out and into chart-by-chart basis instead of song basis #123

Closed zkrising closed 3 years ago

zkrising commented 3 years ago

Although the latter works, its transparently a hack. This needs to be pulled out unto chart documents.

This would add some overhead to chart calls, but ultimately shouldn't be that bad. We're allowed to store duplicate difficulties now, maybe we should change up our system a bit so that any difficulty name is legal? This wouldn't actually be an issue for anything other than colorizing difficulties. -- Just storing old charts under "DJT ANOTHER", and hidden by default? seems sensible.

zkrising commented 3 years ago

Gonna sleep on this - there might be something good to it. I guess the only bad part would then be performing lookups. If we change the difficulty names we could screw ourselves over with that

humanizedDifficulty perhaps? Maybe we're in the wrong place entirely since we want difficulties to simutaneously be unique and non-unique.

zkrising commented 3 years ago

This is definitely more sensible, but brings the obvious issue with "Humanized Difficulty" names. We could possibly kill two birds with one stone with the versions field? We could humanise the start and end of that and use that as the UI wrapper around difficulty.

I.e. [12,13,14,15] SP ANOTHER -> "HAPPYSKY->DJTROOPERS SP ANOTHER" ? Could work.

Regardless, this is definitely the approach to work with.

zkrising commented 3 years ago

Done! I'm so good...