zkry / awqat

أوقات الصلاة
16 stars 5 forks source link

Incorrect Isha angle in the preset of Umm al-Qura #7

Closed abougouffa closed 2 years ago

abougouffa commented 2 years ago

Hello, first, I would like to thank you for this package.

I want to bring your attention to the preset of Umm al-Qura University

https://github.com/zkry/awqat/blob/1664c7e0403367ca2713115874d25fdcf661a990/awqat.el#L128-L130

In fact, the angle for Isha is not defined, Umm al-Qura do not use an angle based calculation for Isha.

Instead, it adds a fixed amount of time to the Maghrib time as follows:

zkry commented 2 years ago

Thanks for bringing this up and working on it! It will definitely be good to have this fixed 👍

abougouffa commented 2 years ago

@zkry Thank you for your reply,

I'm glad to contribute to this project!