search

zksecurity / noname

Noname: a programming language to write zkapps
https://zksecurity.github.io/noname/
179 stars 46 forks source link

properly handle errors in r1cs backend #102

Closed eightfilms closed 3 months ago

eightfilms commented 4 months ago

100 revealed that in src/backends/r1cs/snarkjs.rs that there are a few places where errors are left unhandled - these should not be silenced like in that PR, but should be properly handled.

Related comments: https://github.com/zksecurity/noname/pull/100#discussion_r1628383632 https://github.com/zksecurity/noname/pull/100#discussion_r1628384126

katat commented 4 months ago

Nice spots. I think they are mostly related to file IO errors. We could create some error types in noname to wrap them up for the 3rd party library.