search

zksecurity / noname

Noname: a programming language to write zkapps
https://zksecurity.github.io/noname/
161 stars 35 forks source link

chore: refactor `SnarkjsExporter` and `WitnessWriter` to handle errors #105

Closed eightfilms closed 1 month ago

eightfilms commented 1 month ago

Closes #102 Related: #100, addresses comments on unused results

Originally, all Results were ignored. This PR updates the two structs/impls in question to: use either the appropriate io::Result or the standard std::result::Result (which the circom dep returns)

katat commented 1 month ago

Nice!

I think this is a good chance for us to figure out how to get these IO errors bubble up and be compatible with the miette::result at the top.