zksecurity / noname

Noname: a programming language to write zkapps
https://zksecurity.github.io/noname/
161 stars 35 forks source link

Add support for the not equal operator #119

Closed lognorman20 closed 1 month ago

lognorman20 commented 1 month ago

Adds the != operator for variables in Noname, closes #113.

Summary of changes:

mimoo commented 1 month ago

code looks good to me, but as pointed out do you want to try first in another PR if the solution using equal_cell leads to less constraints?

lognorman20 commented 1 month ago

yes i can try to reduce constraints in another pr

lognorman20 commented 1 month ago

@mimoo addressed in #128!

mimoo commented 1 month ago

maybe is_equal should use is_zero(a-b) now?

anyway thanks so much!